Contrib.social

Allow image upload AND remote images

Open on Drupal.org →
Created on 27 March 2023, over 1 year ago
Updated 13 February 2024, 10 months ago

Problem/Motivation

At the moment with the current state of the art of CK5 implementation, you have to choose in your formatted text fields when you configure images if you want to allow remote Images NOR Uploaded images. You can't have both.

It would be fair to allow both. Especially with CK4 when we could do it.

Steps to reproduce

Install core 9.5.7 with standard profile.
Try to create an article. You can insert an image in the body field. The image will have to be uploaded.
Now, go edit the basic HTML text format. Disable image uploads while preserving the image button in your toolbar. Save.
Try to create another article. You can now insert image through their URL.

Proposed resolution

Add a checkbox to image insertion filter to expose remote images insertion.
If neither image upload or url insertion is enabled, add a validation error to the form.

Upgrade path is needed to respect the current sites configuration and not enable this feature without explicit consent.

Remaining tasks

* Expose filter option
* Write upgrade path

User interface changes

* New form option in the filter configuration
* Image button let user select the image type to insert (remote or local).

API changes

n/a.

Data model changes

n/a.

Release notes snippet

n/a.

✨ Feature request
Status

Closed: works as designed

Version

11.0 🔥

Component
CKEditor 5  →

Last updated 3 days ago

Created by

🇫🇷France artusamak Bzh

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Issue created by @artusamak
  • Comment over 1 year ago →
    cilefen
  • Status changed to Postponed: needs info over 1 year ago
  • Comment over 1 year ago →
    🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺

    Especially with CK4 when we could do it.

    Did CKEditor 4 in Drupal core allow this out of the box? AFAICT that was not the case.

    That's also what I wrote in #3222756-45: Allow using images from external source → — we specifically wanted to retain the same behavior that CKEditor 4 had!

    In the Drupal 8/CKEditor 4 days this could've been justifiable. But with Media in Drupal core, I don't see the value of this — why not at least add remote images to your media library to have a single place to audit them? In fact, why not just use local image media?

  • Status changed to Closed: works as designed 10 months ago
  • Comment 10 months ago →
    🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024