Drupal 10 compatability

Created on 27 March 2023, over 1 year ago
Updated 1 June 2023, over 1 year ago

Problem/Motivation

The code needs to be updated to be compatible with Drupal 10.

Currently module.info files need to be updated to support the latest versions of drupal. Compatibility with Drupal 10 will require dropping support for Drupal 8.

Proposed resolution

* Update the info files to support `core_version_requirement: ^9 || ^10`

📌 Task
Status

Fixed

Version

3.0

Component

Code

Created by

🇬🇧United Kingdom kalpaitch

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @kalpaitch
  • @kalpaitch opened merge request.
  • 🇬🇧United Kingdom arcaic Milton Keynes

    I couldn't get the patch in #2 to apply. It would patch the view module info yml ok but fail on the main modules info.yml.

    I tried to recreate it and my patch was exactly the same as kalpaitchs. V weird.

    I've created my own version that closes the bracket on the modules description and adds a package entry in the YML. This applies ok for me.

    I suggest that if anyone has trouble with one or the other then try the other.

    • Eli-T committed 407f83bb on 8.x-2.x
      Issue #3350663 by kalpaitch, arcaic, eli-t: specify Drupal 10...
  • Status changed to Needs work over 1 year ago
  • 🇬🇧United Kingdom Eli-T Manchester

    I've committed the updated version constraints to the 8.x-2.x branch but composer still won't load the dev release alongside a clean install of Drupal 10.

    ❯ ddev exec composer require drupal/govuk_notify:dev-2.x
    ./composer.json has been updated
    Running composer update drupal/govuk_notify
    Loading composer repositories with package information
    Updating dependencies
    Your requirements could not be resolved to an installable set of packages.
    
      Problem 1
        - php-http/guzzle6-adapter v0.1.0 requires guzzlehttp/guzzle ~6.0 -> found guzzlehttp/guzzle[6.0.0, ..., 6.5.x-dev] but the package is fixed to 7.5.1 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.
        - php-http/guzzle6-adapter[v0.2.0, ..., v0.2.1] require php-http/client-tools ^0.1 -> could not be found in any version, there may be a typo in the package name.
        - php-http/guzzle6-adapter[dev-master, v0.3.0, ..., v0.4.0, v1.1.0, ..., v1.1.1, v2.0.2, ..., 2.x-dev] require guzzlehttp/guzzle ^6.0 -> found guzzlehttp/guzzle[6.0.0, ..., 6.5.x-dev] but the package is fixed to 7.5.1 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.
        - php-http/guzzle6-adapter[v2.0.0, ..., v2.0.1] require php ^7.1 -> your php version (8.1.11) does not satisfy that requirement.
        - drupal/govuk_notify dev-2.x requires php-http/guzzle6-adapter * -> satisfiable by php-http/guzzle6-adapter[dev-master, v0.1.0, ..., v0.4.1, v1.0.0, v1.1.0, v1.1.1, v2.0.0, v2.0.1, v2.0.2, 2.x-dev].
        - Root composer.json requires drupal/govuk_notify dev-2.x -> satisfiable by drupal/govuk_notify[dev-2.x].
    
    Potential causes:
     - A typo in the package name
     - The package is not available in a stable-enough version according to your minimum-stability setting
       see <https://getcomposer.org/doc/04-schema.md#minimum-stability> for more details.
     - It's a private package and you forgot to add a custom repository to find it
    
    Read <https://getcomposer.org/doc/articles/troubleshooting.md> for further common problems.
    
    Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.
    
    Installation failed, reverting ./composer.json and ./composer.lock to their original content.
    Failed to execute command composer require drupal/govuk_notify:dev-2.x: exit status 2

    I'll take a look tomorrow.

    • Eli-T committed 03915186 on 8.x-2.x
      Revert "Issue #3350663 by kalpaitch, arcaic, eli-t: specify Drupal 10...
  • 🇬🇧United Kingdom Eli-T Manchester

    I've reverted the commit that allows Drupal 10 in the version constraints.

    govuk_notify currently has a composer requirement for php-http/guzzle6-adapter, but drupal/core-recommended for Drupal 10 requires Guzzle 7.

    So we will need separate releases for govuk_notify to support 9 using guzzle6-adapter and 10 using guzzle7-adapter.

  • 🇬🇧United Kingdom Eli-T Manchester
    • Eli-T committed 964e0d87 on 3.0.x
      Issue #3350663 by eli-t: update version constraint to only support...
  • Status changed to Fixed over 1 year ago
  • 🇬🇧United Kingdom Eli-T Manchester

    We now have 3.0.0 to support Drupal 10.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024