Editing an existing price quantity does not update value/unit price/total price

Ah OK... I found an important clue:

In the context of QuantityEventSubscriber::quantityPresave(), $event->quantity->get('unit_price')->fraction returns the old value, and $event->quantity->get('unit_price')->getValue() returns the new value.

This must have something to do with how/when the Fraction module sets the ->fraction property. Maybe it isn't being updated before this event subscriber runs.

I dug in with XDebug and this is what I found...

FractionProperty::getValue() runs first, but there doesn't seem to be any way to get the new value from within that method's context.

QuantityEventSubscriber::quantityPresave() runs afterwards, and $event->quantity->get('unit_price')->fraction still has the old value, but $event->quantity->get('unit_price')->getValue() has the new value.

The merge request I opens doesn't dig any deeper than that. It simply refactors the event listener logic to use getValue() instead of fraction.

I'd prefer to use fraction, at least conceptually. From a DX perspective it feels like I should be able to. I may continue digging into that... but the MR I opened fixes the issue by working around that, so it's worth considering anyway.

I'd prefer to use fraction, at least conceptually. From a DX perspective it feels like I should be able to. I may continue digging into that...

I opened an upstream issue in the Fraction module for this: 🐛 Update fraction and decimal properties via setValue() Fixed

I have a working solution there, so once that gets merged we can update this module to require the new version of Fraction and close this.

This was fixed upstream in Fraction 2.3.0. This module now requires that version as a minimum to fix this issue.

Automatically closed - issue fixed for 2 weeks with no activity.