Convert all JavaScript tests that use dialogs to use waitForDialog()

Problem/Motivation

Follow up for: 🐛 Avoid random failures in JavascriptTestBase when testing functionality in a dialog Needs work

To reduce the chance of getting random fails in JavaScript tests we should convert all JavaScript test that use a dialog to use the AssertDialogTrait added in 🐛 Avoid random failures in JavascriptTestBase when testing functionality in a dialog Needs work

Steps to reproduce

Proposed resolution

Convert all tests that use a dialog to use waitForDialog

Remaining tasks

Make a list of tests that use dialogs
Convert the waitFor assertions that are used to waitForDialog()

User interface changes

API changes

Data model changes

Release notes snippet