Only variables should be passed by reference in intercept_core.module

Created on 24 March 2023, almost 2 years ago

Updated 20 April 2023, almost 2 years ago

Problem/Motivation

Drupal reports a php notice from intercept_core_user_load(): `Notice: Only variables should be passed by reference in intercept_core_user_load() (line 188 of modules/contrib/intercept/modules/intercept_core/intercept_core.module).`

Steps to reproduce

Install the 8.x-1.x branch and authenticate (triggers implementations of hook_ENTITY_TYPE_load() with the `user` entity type) and observe the notice.

Proposed resolution

When loading $profiles in intercept_core_user_load(), first create an array of uids (call it `$uids`, for example), then pass reset($uids) as the `uid` parameter in $profile_storage->loadByProperties().

Remaining tasks

Patch forthcoming.

🐛 Bug report

Status

Fixed

Version

1.0

Component

Code

Created by

🇺🇸United States COBadger

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @COBadger
Comment almost 2 years ago →
🇺🇸United States COBadger
Patch attached.
Issue was unassigned.
Status changed to Needs review almost 2 years ago4:03pm 24 March 2023
Comment almost 2 years ago →
🇺🇸United States COBadger
Needs review.
Comment almost 2 years ago →
🇺🇸United States COBadger
Updated patch. Typo had snuck in to docblock in previous patch.
Comment almost 2 years ago →
🇺🇸United States attheshow
Thanks COBadger! Fixed in the latest release!
Status changed to Fixed almost 2 years ago7:44pm 20 April 2023
Comment almost 2 years ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024