Store assets (and optional regex) in the original public stream when s3fs.use_s3_for_public is set

While this might still need work, I would like an initial review.

On initial glance this sounds similar to ✨ Provide a module for serving agregated CSS and JSS from local public filesystem instead of S3 when option "use_s3_for_public" is used Closed: won't fix . I have some comments in there regarding limitations for multi-frontend deployments that in my opinion make such a feature a poor fit with the current s3fs module, but could be useful for some deployments. I had suggested it would be a good idea to split the patch into its own module project to allow this feature without impacting the s3fs's core design principals.

On quick glance, this would appear to have API changes making it need to be put into 4.x as the earliest version or be refactored not to change API.

There is a chance this may in the future become a partially moot point if 📌 Make css/js optimized assets path configurable Fixed makes it in css/js assets will no longer be stored on public://.

Thanks for the feedback! There's really is not an API change, as everything continues to work exactly the same unless you set a setting.

There's really is not an API change, as everything continues to work exactly the same unless you set a setting.

I saw the new method and was thinking it was a class that was expected to be decorated where this could break code, however since its the StreamWrapper class with the new method I would only expect it to be extended so that does on a quick glance appear safe.

This still leaves the points from ✨ Provide a module for serving agregated CSS and JSS from local public filesystem instead of S3 when option "use_s3_for_public" is used Closed: won't fix where I feel this would be better as an additional contribute module outside of s3fs, though I'm leaving this open for a time for a differing opinion to be raised.

📌 Make css/js optimized assets path configurable Fixed has made it into core 10.1.

With that in mind and the previous issues with CSS/JS generation that would be near impossible to fix in earlier versions of Drupal I'm going to close this as outdated.

Once a site upgrades to D10.1 s3fs will NOT be storing any CSS/JS assets. This seems like the cleanest way forward for this.

cmlara → closed merge request !28