Drupal 10 Compatibility fixes

Let's see if the bot will generate us a patch.

Here is manual output of upgrade_status:analyze

 ddev drush upgrade_status:analyze ss_back_to_top_button
 [notice] Processing /var/www/html/docroot/modules/contrib/site_studio_back_to_top_button.

================================================================================
Site Studio Back To Top Button, --
Scanned on Thu, 03/23/2023 - 21:18

FILE: modules/contrib/site_studio_back_to_top_button

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Check manually 0    The 'ss_back_to_top_button' extension is not installed.
                    Cannot check deprecated library use.
--------------------------------------------------------------------------------

FILE:
modules/contrib/site_studio_back_to_top_button/templates/ss-back-to-top-button.h
tml.twig

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Check manually 2    The 'ss_back_to_top_button/ss-back-to-top-button' library is
                    not defined because the defining extension is not installed.
                    Cannot decide if it is deprecated or not.
--------------------------------------------------------------------------------

FILE:
modules/contrib/site_studio_back_to_top_button/ss_back_to_top_button.info.yml

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^8 || ^9 is not
                    compatible with the next major version of Drupal core. See
                    https://drupal.org/node/3070687.
--------------------------------------------------------------------------------

Patch fixed D10 compatibility.

After applying patch and enabling module, I get zero issues with upgrade_status:

ddev drush upgrade_status:analyze ss_back_to_top_button
 [notice] Processing /var/www/html/docroot/modules/contrib/site_studio_back_to_top_button.

================================================================================
Site Studio Back To Top Button, --
Scanned on Thu, 03/23/2023 - 21:29

No known issues found.

And no issues with mglaman/drupal-check:

❯ ddev exec php vendor/bin/drupal-check -d docroot/modules/contrib/site_studio_back_to_top_button
 2/2 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


 [OK] No errors

Thanks for using drupal-check!

Consider sponsoring the development of the maintainers which make drupal-check possible:

- phpstan (ondrejmirtes): https://github.com/sponsors/ondrejmirtes
- phpstan-deprecation-rules (ondrejmirtes)): https://github.com/sponsors/ondrejmirtes
- phpstan-drupal (mglaman)): https://github.com/sponsors/mglaman
- drupal-check (mglaman)): https://github.com/sponsors/mglaman

Applying patch manually. Thanks!

Unfortunately there is more work required that wasn't detected by Drupal rector and Drupal check, which focus on PHP compatibility only.

There are errors in JS console on Drupal 10 installation related to jquery.once which was Deprecated in Drupal 10.

Here is the change record with notes on how this should be refactored.

https://www.drupal.org/node/3158256 →

I see that the back_to_top → Drupal module has 3.x version that has already taken on this challenge of doing a rewrite of their javascript to use modern vanilla js.

In an ideal world, the suggested approach would be to convert the custom JS provided by this module to vanilla javascript so that the dependency on jQuery can be removed and convert to using the new drupal/once npm package. However, I believe Site Studio itself still relies heavily on jQuery for many things, plus this module uses animations to scroll to the top will make the rewrite in vanilla JS more difficult, but you might be able to borrow code from back_to_top, OR perhaps decide to switch gears and add that module as a dependency.

Drupal 10 Compatibility added.

Automatically closed - issue fixed for 2 weeks with no activity.