- Issue created by @vbouchet
- Status changed to Needs review
over 1 year ago 3:08pm 21 March 2023 - π«π·France vbouchet
Please find a patch which rework the validateForm(), submitForm() and layout_builder_component_attributes_preprocess_block().
It is more complex to adapt the buildForm() as some labels and description are different per element type. Reworking this may reduce the code duplication but will make it harder to understand and maintain.
The last submitted patch, 2: reduce_code_duplicate-3349365-2.patch, failed testing. View results β
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.-
Chris Burge β
committed c6f6e442 on 2.x authored by
vbouchet β
Issue #3349365 by vbouchet: Reduce code duplicate
-
Chris Burge β
committed c6f6e442 on 2.x authored by
vbouchet β
- Status changed to Fixed
over 1 year ago 12:23pm 18 September 2023 - Status changed to Needs work
about 1 year ago 2:30pm 18 September 2023 - Status changed to Needs review
about 1 year ago 3:06pm 18 September 2023 - Status changed to Fixed
about 1 year ago 5:19pm 18 September 2023 - πΊπΈUnited States Chris Burge
The regression is being worked in #3388042: Regression: block attribute classes end up on block title as well β .
Automatically closed - issue fixed for 2 weeks with no activity.