Display booking success message also when one-click booking is enabled

I agree, based on the API call the "one-click" booking is doing the success message set on the Calendar should already be there available, and it just needs to be printed onto the page. The rest of those features also make sense and should get implemented.

@josh.fabean I started looking into this and saw that the one-click booking is not using the Drupal ajax API and I'm uncertain if that could be easily changed without breaking other things. If we changed that, the API controller would respond with an AjaxResponse instead of a JsonResponse and that would allow all sorts of nice things like e.g. adding a MessageCommand which would then be automatically handled without us having to do all that manually.

Is the API used by other clients too or is it just for the one-click booking and could be updated?

That API call is currently only used inside the module for the one click booking, but it's existed for a while and how to use it is on the README so how many people are using it would be impossible to know. So I think that leaves the options of, creating a new API endpoint to not break this one, or update this one and move it to a version of 2.3.x and list it as a potential breaking change with upgrade instructions.

OK, I'll go for a separate endpoint then.

The MR now contains the re-implementation of the one-click-booking with Drupal's ajax and it also displays the message(s) collected by Drupal during that request. Adding the same for cancellation will then be addressed in the other issue.

Sorry @josh.fabean for my late response, I've now fixed that last issue.

Just committed https://git.drupalcode.org/project/bookable_calendar/-/merge_requests/28... to address the cancellation emails from ✨ Improve booking cancellation Fixed

Now working on the on-click-cancellation feature.

Thanks, I'll get this tested and merged in this week.

OK, I've now committed https://git.drupalcode.org/project/bookable_calendar/-/merge_requests/28... which does the one-click-cancel. The JS code is not complete yet, but it's functional and can be tested.

Yeah, the last commit at https://git.drupalcode.org/project/bookable_calendar/-/merge_requests/28... resolved the final remaining issues from my POV. It's ready to go, at least for your review of course ;-)

Really looking forward to your response.

Just merged that all in.

Automatically closed - issue fixed for 2 weeks with no activity.