Retain View Mode When Returning to Content Editing from Full Window Preview

Created on 18 March 2023, over 1 year ago

Updated 10 May 2024, 7 months ago

Steps to reproduce

* Click toggle preview button.
* Make content changes
* Click the refresh button.
* Change to a non-default view mode.
* Click on the new window button.
* Confirm that the new window preview uses the view mode that was previously selected.
* Click on the back to content editing link.
* Click the toggle preview button.
* Note that the view mode is reset to the default.

Would be nice if the selected view mode continued to persist. This will be even more noticeable if we ever make it possible for the preview panel to be open by default.

Marked this as minor - especially considering that it seems possible that functionality that impacts this, like the new window preview, may still change. But still wanted to make sure this didn't get lost.

Proposed resolution

Easiest way I can think to resolve this would be to pass the view mode to the node form as a query string parameter and then set the view mode state accordingly on load.

🐛 Bug report

Status

Active

Version

1.0

Component

Code

Created by

🇺🇸United States brianperry

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @brianperry
Comment over 1 year ago →
🇺🇸United States cosmicdreams Minneapolis/St. Paul
@brianperry: @mherchel suggested that we might explore using a browser's localstorage as a means of storing state for things like this.
Comment over 1 year ago →
🇺🇸United States cosmicdreams Minneapolis/St. Paul
if 🌱 Hide View Mode behind a feature toggle Fixed lands then this issue will have less exposure, but will still be important to fix.
Comment 7 months ago →
🇺🇸United States cosmicdreams Minneapolis/St. Paul
I'm noticing that the issue is a bit worse that mentioned in the testing steps.

We're not preserving the view mode at any step. I wonder if we were before.

This mechanism depends on our storing of configuration in localStorage. I'll inspect if that's working properly.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024