system.mail.inc: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated

Thanks for reporting this. Adding some related issues.

I think this fix looks good, thanks! The similar change is needed for D10 (see the parent issue), but there is a Request class used and it returns a default value in case the specific $_SERVER key is not defined. So a fix will be a bit different there.

Adding a tag for a final review.

Just a note, we should keep an eye on these two issues:

🐛 Truncated MailFrom address - Incorrect Windows detection Active
🐛 PHP Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in docroot/core/lib/Drupal/Core/Mail/Plugin/Mail/PhpMail.php on line 112 Needs work

But I suppose that for D7 it would be better to fix this deprecation message as the patch proposes (we have already done it in #2356055: Notice in includes/mail.inc define → ) and then see, what to do with the check in overall in the separate existing issue referenced above.

The windows check is probably also related to this issue: 🐛 [D7] PhpMail : broken mail headers in PHP 8.0+ because of LF characters Needs work

Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.