Remove hardcoded example string from menu component

Created on 16 March 2023, about 2 years ago
Updated 19 June 2023, almost 2 years ago

Remaining tasks

Remove hardcoded example string from menu component

📌 Task
Status

Needs work

Version

1.0

Component

Code

Created by

🇫🇷France pdureau Paris

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @pdureau
    • pdureau committed 00c2f58d on 1.0.x
      Issue #3348562 by pdureau: Remove hardcoded example string from menu...
  • Status changed to Needs work almost 2 years ago
  • 🇫🇷France pdureau Paris

    DONE, but there is still a little issue in menu component:

        <li class="mzp-c-menu-category mzp-has-drop-down mzp-js-expandable">
          {% set url = item.url|default(item_attributes.href|default("#")) %}
          <a{{ item_attributes.setAttribute('aria-haspopup', 'true').setAttribute('href', url) }}>{{ item.title }}</a>
            {{ panels }}
        </li> 

    Panels need to be inside a menu item to works. It will create issues because:

    • Some menu items has no panels
    • "panels" variable contains all panels
Production build 0.71.5 2024