Contrib.social

Props must be settings instead of fields

Open on Drupal.org →
Created on 14 March 2023, almost 2 years ago
Updated 10 November 2023, about 1 year ago

Problem/Motivation

Some definitions:

  • slots are free renderables (render array, renderable objects, scalars, list of renderables...), which allows them to be mapped to regions of a layout, to rows and areas of a view, to groups of a field group...
  • props are controlled values (boolean, enums, tokens...), they are used in the template for HTML attribute values, for conditions, or some calculations...

It is good practice in the UI Suite community to set slots as fields and props as settings, and it works better with Layout Builder like that.

Proposed resolution

Can be done now

Button

  • url must be an url setting

Card

  • link must be an url setting

Must wait ✨ Add links setting type Needs review

Footer:

  • social must be a menu setting
  • terms must be a menu setting

Footer section

  • list must be a menu setting

Menu item

  • items must be a menu setting

Breadcrumb

  • items must be a menu setting

Menu list

  • items must be a menu setting

API changes

Yes, on the site building side.

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

🇫🇷France pdureau Paris

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024