Contrib.social

How to handle content_attributes

Open on Drupal.org →
Created on 14 March 2023, almost 2 years ago
Updated 4 June 2023, over 1 year ago

Problem/Motivation

I've been testing cl_server with storybook and sdc module, attempting to develop a story for 📌 Create new SDC component for Olivero (header-search) Needs work . The component expects a content_attributes array that it can add the data-drupal-selector to. I think ultimately the component should be refactored to not required that, but in the meantime it seems we should be able to support it.

Steps to reproduce

* Install SDC
* Set up cl_server with storybook
* Apply patch from #3347736
* Add the following to header-search-wide.stories.yml

title: Core/Olivero/Header Search Wide
stories:
  - name: 1. Default
    args:
      label: "Does this work"
      content_attributes: {}

Note the class and data attributes are not added and the javascript fails.

Proposed resolution

¯\_(ツ)_/¯

Remaining tasks

User interface changes

API changes

Data model changes

💬 Support request
Status

Fixed

Version

2.0

Component

Code

Created by

🇦🇺Australia mstrelan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @mstrelan
  • Comment almost 2 years ago →
    🇦🇺Australia mstrelan

    Not sure but this might be better suited for sdc_examples module.

  • Comment over 1 year ago →
    e0ipso Can Picafort

    Storybook only supports basic data types for their knobs and controls. The content attributes is a PHP object in that component.

    One potential solution is to make the input an object, and the create the attributes inside the component via Twig's create_attribute.

    Another solution is to be more expressive about the kind of attributes you need and define each one of them separately.

    In any case, there is nothing we can do to add support from here.

  • Status changed to Fixed over 1 year ago
  • Comment over 1 year ago →
    e0ipso Can Picafort
  • Comment over 1 year ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024