Introduce a FetchModeTrait to allow emulating PDO fetch modes

Issue created by @mondrake
Comment over 1 year ago →
🇮🇹Italy mondrake 🇮🇹
Patch built on top of 🐛 Implement statement classes using \Iterator to fix memory usage regression and prevent rewinding Fixed , suggest to wait for that to happen first.
@mondrake opened merge request.
Status changed to Needs review over 1 year ago8:45pm 17 March 2023
Comment over 1 year ago →
🇮🇹Italy mondrake 🇮🇹
Parent got committed. Put the patch in a MR, for review.
Status changed to RTBC over 1 year ago10:17pm 17 March 2023
Comment over 1 year ago →
🇳🇱Netherlands daffie
All code changes look good to me.
We already have testing for all the changes in the database FetchTest.
For me it is RTBC.
Comment over 1 year ago →
🇮🇹Italy mondrake 🇮🇹
FWIW, just implemented the trait in the mysqli driver on Github, https://github.com/mondrake/mysqli/commit/52da30ef0f1ab47d18ace0c7f4e89d...

All good.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
29,202 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
29,207 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
29,283 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
29,302 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
29,302 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
29,300 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
12:01
8:31
Running
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
29,366 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
29,367 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
29,374 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
29,379 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
29,380 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
29,380 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
29,383 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
29,388 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
29,388 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
29,388 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
29,388 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
29,388 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
29,395 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
29,399 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
29,393 pass, 2 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
29,399 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
29,400 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
29,404 pass, 4 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
Build Successful
Status changed to Needs work over 1 year ago4:15pm 7 June 2023
Comment over 1 year ago →
🇺🇸United States Amber Himes Matz Portland, OR USA
Looks like this MR needs a rebase, as the merge is blocked. It might work to just click the Rebase button in the MR link.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
29,418 pass
Status changed to RTBC over 1 year ago4:33pm 7 June 2023
Comment over 1 year ago →
🇮🇹Italy mondrake 🇮🇹
Done
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,434 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & sqlite-3.34
last update over 1 year ago
29,434 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
29,434 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
29,429 pass, 2 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
29,437 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
29,445 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
29,449 pass, 1 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
29,499 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
29,499 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
29,508 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
29,553 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
29,553 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
42:01
40:51
Running
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
29,565 pass, 2 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
29,569 pass, 1 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
29,801 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
29,801 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update over 1 year ago
29,802 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,800 pass, 2 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,806 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
57:00
53:21
Running
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,815 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,815 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,822 pass

catch → committed b156dbda on 11.x

Issue #3347497 by mondrake, daffie: Introduce a FetchModeTrait to allow...

Status changed to Fixed over 1 year ago9:10pm 19 July 2023
Comment over 1 year ago →
🇬🇧United Kingdom catch
Looks good to me, will make more sense once we add the mysqli driver but chicken-and-egg with that.

Committed/pushed to 11.x, thanks!
Comment over 1 year ago →
System Message
mondrake → closed merge request !3676
Comment over 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Introduce a FetchModeTrait to allow emulating PDO fetch modes

Problem/Motivation

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments & Activities