[META] farmOS 3.x Breaking Changes

@symioquine started this forum topic a few months ago, which was the original inspiration for this: https://farmos.discourse.group/t/proposal-for-farmos-3-x-core-datamodel-...

One thing I'd like to consider is adding more injected dependencies to the QuickFormBase class, like entity_type.manager, asset.location, and other commonly used services.

Maybe we can refactor some of our classes to take advantage of this technique: https://www.hashbangcode.com/article/drupal-9-extending-drupal-base-clas...

Allow multiple material terms on material quantities: https://farmos.discourse.group/t/allowing-material-quantities-link-to-mu...

Deprecate and remove farm_migrate module (for migrating from 1.x). Require that data is migrate from v1 to v2, and then upgrade v2 to v3 (no migration necessary).

Linking to ✨ Support allowed_values_function Closed: won't fix so I remember to add a patch for that if it isn't merged before 3.x.

Another idea that came up in the forum (https://farmos.discourse.group/t/add-setup-page-to-farmos-core/1712/9): should we prevent taxonomy terms from having multiple parents? And if so, how do we deal with terms that may already have multiple parents. This should have a dedicated discussion thread in the forum - I just want to note it here so I don't forget about it.

Linking to these two feature requests so we can consider including them in 3.x: #3390486: Add an Ontology URL field to all taxonomy terms → + #3390489: Add a Convention taxonomy reference field to Assets and Logs →

Not a breaking change, but it would be great if we could add Image/File fields to all taxonomy terms too: https://github.com/farmOS/farmOS/pull/536

Potential breaking change to consider: 🐛 Managed roles assume bundle permissions for quantities Fixed

I think all of the breaking changes that we can make are complete in my 3.x branch (except for one that @paul121 is currently working on, mentioned below). We won't have time to make any other big changes, unfortunately, so they will need to wait until 4.x.

I patched jsonapi_schema to fix ✨ Support allowed_values_function Closed: won't fix .

#3382616: Remove v1 migrations from farmOS 3.x → is done.

✨ Allow material quantities to reference multiple material types Fixed is done.

The last big one is the upgrade of the simple_oauth module from v5 to v6, which @paul121 is working on currently. We may include that in the 3.x branch when we push it to origin, or open a PR for it after that, but before we tag the first 3.0.0-beta1 release.

I patched

jsonapi_schema

to fix ✨ Support allowed_values_function Closed: won't fix .

Update: I decided to remove this, and instead I'm going to propose we take this approach instead: ✨ Use OptionsProviderInterface::getPossibleOptions() for allowed field values (anyOf / oneOf) Needs review - This will most likely be included in a follow-up release of farmOS 3.x. It is not a breaking change - it only adds to the existing JSON Schema.

Closing this, but I linked to it from 🌱 [META] farmOS 4.x Active so we can review again in case there are breaking changes we want to consider for 4.x.

Automatically closed - issue fixed for 2 weeks with no activity.