Contrib.social

Remove useless service for JWT class in top-level module

Open on Drupal.org →
Created on 11 March 2023, almost 2 years ago

Problem/Motivation

In jwt.services.yml there is a service defined jwt.firebase.php-jwt which is really pointless. It has no dependencies and all static methods.

Also - we are only allowing the 1st argument to JwtTranscoder to be a \Firebase\JWT\JWT object or subclass.

Proposed resolution

Replace the service used for DI injection with simply a class name to be instantiated,

Other libraries like lcobucci/jwt could be swapped in with a simple wrapper class that implements encode() and decocode() methods and then calls the issue() or parse() methods in that library with the appropriate arguments.
https://github.com/lcobucci/jwt/blob/5.1.x/docs/quick-start.md

Remaining tasks

post patch, verify tests pass.

User interface changes

n/a

API changes

constructor change, remove a service

Data model changes

n/a

📌 Task
Status

Fixed

Version

2.0

Component

Code

Created by

🇺🇸United States pwolanin

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024