eca_base: Provide a mechanic to recursively replace tokens

Had to add a fix to the TokenDecoratorTrait, which should be backported to 1.1.x (MR 323) and 1.0.x (needs to be cherry-picked from MR 323). The fix makes sure that token replacement is not run twice, even when the decorated token services is the core one, while contrib Token may be installed. I'm not sure whether this comes from a change in D10.x, as I thought I tested that aspect in the past thoroughly.

MR322 contains the fix already and is meant for 1.2.x. But we could also backport MR322 to 1.1.x, however it contains new features and that would not be included in 1.1.x usually.

Very nice implementation, thanks @mxh - and a max nesting level of 5 really seems reasonable.

It's true that it provides new functionality. As this is encapsulated in a new plugin, it won't really impact any existing installation and only those who need this feature will ever notice that it's there. So, I'm not against porting the feature to 1.1.x

Others?

Tests are currently failing on 1.2.x. Not sure how you merged the commits, did you perform a rebase? MR322 used to pass all tests as can be seen in #4, but something broke it (see commits after #9).

I had to rebase for MR325, see https://www.drupal.org/project/eca/issues/3347915#comment-14972430 ✨ eca_content - "Entity: load via reference" action - tokens on field ref Fixed where I mentioned something odd, that suddenly a test from 1.1 appeared in 1.2 which wasn't there before. Maybe it's caused by that? I believe there shouldn't be any test in 1.1 which doesn't also exist in 1.2 - but I wasn't able to track this issue yet.

My guess is that might be coming from 📌 Let "Token: set value" use new objects when referring to existing ones Fixed . So probably not because of the rebase, but because of the changes made there. Will have a look at it later this day.

MR328 adjusted the tests in accordance to the new behavior of "Token: set value" as introduced in 📌 Let "Token: set value" use new objects when referring to existing ones Fixed .

Automatically closed - issue fixed for 2 weeks with no activity.

Thank you all for this work!

This might be a silly question from an uninformed user, but it seems that the changes made in the 1.2.x branch were virtually all forgotten in the 1.1.x branch.

The changes I am talking about:

Merge request from 1.2.x: https://git.drupalcode.org/project/eca/-/merge_requests/322/diffs#9fb25f...

After adding these changes to the 1.1.x version of the dev module manually, the action is there, and functions as expected. Could you maybe commit the changes to the 1.1.x branch aswell?

Thanks in advance!

@dgb-2000 that's on purpose. MR322 contains the new feature which only goes into 1.2 and MR323 went into 1.1 and 1.0 as it contains a bug fix. New features are always only going into major or minor version upgrades, but not into bug fix releases. If you want to stay on 1.1 (as it's recommended) and still want to use one of the new features from the 1.2 branch, then you need to patch your system by applying the relevant MR or patch file.