- Issue created by @spiderman
- @spiderman opened merge request.
- π¨π¦Canada ergonlogic MontrΓ©al, QuΓ©bec π¨π¦
It looks like the tests are failing due to a patch (to
config_devel
) that's not applying. The changes in that patch have been merged, and a new release (1.9) ofconfig_devel
has been published.So it's probably just a matter of removing that patch from our
composer.json
. - π¨π¦Canada spiderman Halifax, NS
Thanks @ergonlogic, I believe you're right. I've removed the patch from composer.json in the issue fork, we'll see what DrupalCI says.
- π¨π¦Canada ambient.impact Toronto
@spiderman: The Config Devel patches are being removed in π Update Config Enforce Devel hooks to work with latest Config Devel issue fork Postponed so I'd prefer to keep things clean if possible and not remove them in this issue.
Also looks like both #2852660: CSS need improvement, causes field following multiselect to wrap β and #3130242: No schema for multiselect.settings β are in Multiselect 2.x so we could remove those patches as well. What do you think?
- π¨π¦Canada spiderman Halifax, NS
If we can show that Multiselect 2.0 still passes tests, then I think that makes sense. Perhaps if we rebase this MR on the newer main branch that removes the D10 compatibility patch which was causing the pipeline to fail, we can see that here?
- π¨π¦Canada ambient.impact Toronto
@spiderman Still passes our tests or theirs? I assume you mean ours?
- Status changed to Fixed
about 2 years ago 6:12pm 6 April 2023 - π¨π¦Canada ambient.impact Toronto
Alright, so I took a real descent into madness with trying to rebase this to the latest default branch, feeling like Git was gaslighting me the whole way. Since the changes are really simple, I just completely nuked the branch (sorry @sensespidey), created a new branch from 1.0.x, recreated the
composer.json
changes, committed, force pushed (not usually a good idea but in this case it was necessary), and then finally was able to merge this. - Assigned to ambient.impact
- Status changed to Needs work
about 2 years ago 6:16pm 6 April 2023 - π¨π¦Canada ambient.impact Toronto
Welp, apparently my attempt at being clever with version constraints might have backfired. Might be due to the older version of PHP we still have set as the default. Gonna try to fix.
- π¨π¦Canada ambient.impact Toronto
I just noticed this was marked as against the 2.0.x branch and not 1.0.x for some reason. Let's see if this fixes the tests.
- Issue was unassigned.
- π¨π¦Canada ambient.impact Toronto
Going to wait a while to re-run the tests because it might be failing due to the testbot using the older
composer.json
with the 1.2 version of the module that doesn't have the configuration schema added, while 2.0 does. - π¨π¦Canada ambient.impact Toronto
Marking as fixed because the schema error was fixed in the default branch by bumping the minimum Multiselect version to 2.0 and the tests now seem to no longer fail with that error. The merge request doesn't have that fix, so it'll still show as failed but it's no longer relevant.
- Status changed to Fixed
almost 2 years ago 5:54pm 21 April 2023 Automatically closed - issue fixed for 2 weeks with no activity.