- Issue created by @tinto
- Status changed to Needs review
almost 2 years ago 12:54am 14 March 2023 - πΊπΈUnited States nathaniel
Started some code for this. Not thoroughly tested, but seems to work.
- π³π±Netherlands tinto Amsterdam
Wow, that's fast! Thanks @nathaniel!
I've tested patch #2 on a fresh Drupal install - both on my local machine and on a new Pantheon site - and it seems to work like a charm on both sites. Here's the combination of modules/versions that I used:
- Drupal 9.5.4
- Album Photos 6.0.x-dev
- Plupload 2.0@beta
- Patch from #2 β
- (our custom workaround module for the plupload file extension error)
- π³π±Netherlands frontmobe Amsterdam
I have applied the patch provided and can confirm that the Plupload uploads now work flawlessly with the batch API!
I tested this locally as well as remotely with a high number of large files, combined with short PHP timeouts configured. The new pluploadSubmitBatch() and batchFinished() functions in PhotosUploadForm.php work and the integration with batch API like progress messages work as expected. No errors show up in the php error log when using the module with the patch applied.
I had to manually apply the patch to Photos module 6.0.2, because the patch is created against de dev version of the module. Any chance of maybe tagging a new release once this patch is confirmed to work ok?
Many thanks for this nice extension of the module, using batch API for bulk uploads really increases stability.
- Status changed to RTBC
almost 2 years ago 5:55pm 15 March 2023 - πΊπΈUnited States nathaniel
Sounds good to me!
Tested "Maximum number of photos per album" and that still works as expected. I'll prep a new release.
- 1a259e26 committed on 6.0.x
Issue #3347017 by Nathaniel: Batch API when using plupload.
- 1a259e26 committed on 6.0.x
- Status changed to Fixed
almost 2 years ago 6:35pm 15 March 2023 - 49f7fc4e committed on 6.0.x
Issue #3347017 by Nathaniel: Work on minor coding standards issues.
- 49f7fc4e committed on 6.0.x
Automatically closed - issue fixed for 2 weeks with no activity.