- Issue created by @tr
- πΊπΈUnited States tr Cascadia
- Status changed to Needs review
over 1 year ago 7:02am 9 March 2023 - πΊπΈUnited States tr Cascadia
You know, actually there were a number of reverts, additions then deletions, etc. across those commits, so I'm just going to squash the commits and re-roll the patch to apply to
rules_ui.listing.js
.In the core repository the command I used to see the changes to
views_ui.listing.js
was:
git diff 5b657b15b810 views_ui.listing.js
Where 5b657b15b810 is the commit before #3101543: Update core JavaScript dependencies listed in package.json β .
That yields the following patch, which I uploaded here as3346889-update-views-ui-listing-js.txt
(named as a .txt file because it applies to core, not to rules).I re-rolled it to be the following for rules:
3346889-update-rules-ui-listing-js.patch
The differences between the two are shown in
diffs.txt
. You will see that aside from changing some CSS selectors to use the word "rules" instead of "views", the only changes are comments.Also, because we're changing JavaScript dependencies, we need to worry about changing
rules.libraries.yml
As with the above,git diff 5b657b15b810 views_ui.libraries.yml
shows that the only relevant change was to changejquery/once
tocore/once
.So included in
3346889-update-rules-ui-listing-js.patch
I have added these same changes torules.libraries.yml
. - πΊπΈUnited States tr Cascadia
Well, as is usual when copying core code, there are some JavaScript coding standard violations in there. I am not going to clean those up because I want to keep
rules_ui.listing.js
as close as possible to the coreviews_ui.listing.js
in order to make it easier to maintain.But I am going to add some text at the top in the file comments that explains where rules_ui.listing.js was forked from and which core commit it is current with. That way it will be easier to update in the future if necessary.
- Status changed to Fixed
over 1 year ago 8:49am 9 March 2023 - πΊπΈUnited States tr Cascadia
This fixed the one test fail due to jquery.once, and didn't cause any further failures. This fix is required for continued D10 compatibility. I manually tested it and it works.
Committed. Automatically closed - issue fixed for 2 weeks with no activity.