Safeguard against missing policy config entries

Here is the patch that worked for us.

I can't reproduce this. How do you get $this->configuration['swiftmailer'] or $this->configuration['plain'] to be missing?

I too am getting this error a lot in the logs and the cause is related to upgrading from previous versions, etc.

At some point in the past I upgraded from an early beta version of Drupal Symfony Mailer which didn't include the swiftmailer emulation. By simply re-saving the effected policy (*All*) in my case this has gone away

Thanks @intrafusion.

When you upgraded, this missing values should have been fixed automatically by the database update, see symfony_mailer_update_10006(). Perhaps the update was missed, or configuration was imported from an "old" version into a "new" version.

There have been various similar bugs to this one with other policy elements (email adjusters). In the past I said it wasn't a bug because it shouldn't happen in normal cases. However people keep hitting these problems, so maybe we should do something. If so, then let's fix it for all of them at once, and I would like to consider the best way to fix it.

Thanks @AdamPS, I originally installed 1.0.0-alpha3 and updated several times along the way (but no real idea when and what would have been updated)

I agree totally with what you're saying about symfony_mailer_update_10006() but could this have been missed when moving between 1.0/1.1 and 1.2 releases?

It should not be possible to miss an update, no matter what sequence of releases you take or skip. However it can go wrong if you run the update hook, then import older config that has not been updated (because the hook won't run again).

OK there is a bug - in settingsForm() the configuration values may be missing (when adding a policy element) so should be safeguarded. Mostly the error gets hidden somehow by AJAX, however some people are hitting it for the body field on 🐛 Error creating new policy body field Fixed . I'll fix this on the other issue.