- Issue created by @eojthebrave
-
eojthebrave β
committed 3d8fe38a on 4.x
Issue #3346810 by eojthebrave: RecurlyPushListenerController doesn't...
-
eojthebrave β
committed 3d8fe38a on 4.x
- πΊπΈUnited States eojthebrave Minneapolis, MN
I added a commit to the 4.x branch that fixes the bug so that push notifications can actually be processed now. However, I also noticed there are no tests for push notifications so it would be good to add some tests too.
- @eojthebrave opened merge request.
- Status changed to Needs review
over 1 year ago 6:18pm 23 March 2023 - πΊπΈUnited States eojthebrave Minneapolis, MN
Here's an MR that adds tests for the push notification controller. I had to make one change to the code in the controller, switching from `file_get_contents('php://input')` to `$request->getContent()` to make it easier to mock the request. And, this is probably a more appropriate use of the Drupal request API anyway. This doesn't change anything about how this works for anyone's current implementations. Just adds tests.
-
eojthebrave β
committed d180012b on 4.x
Issue #3346810 by eojthebrave: RecurlyPushListenerController doesn't...
-
eojthebrave β
committed d180012b on 4.x
- Status changed to Fixed
over 1 year ago 9:04pm 23 March 2023 Automatically closed - issue fixed for 2 weeks with no activity.