- Issue created by @danflanagan8
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 6:28pm 8 March 2023 - First commit to issue fork.
- @nikolayyenbakhtov opened merge request.
- @nikolayyenbakhtov opened merge request.
-
NikolayYenbakhtov β
committed d15fa0a0 on 2.x
Resolve #3346791 "Add automated test"
-
NikolayYenbakhtov β
committed d15fa0a0 on 2.x
- π°πΏKazakhstan NikolayYenbakhtov
Merged, danflanagan8 thanks for contributing!
- Status changed to Needs work
almost 2 years ago 1:53pm 9 March 2023 - πΊπΈUnited States danflanagan8 St. Louis, US
Hi, @NikolayYenbakhtov
Thanks for this module!
The next step here is to configure the project to run automated tests on drupal.org. You can click the "Automated Tests" tab on the project page to get to the form you can configure automated testing β .
I would recommend adding
php8.1/mysql5.7/Drupal 9 supported
as "Run on commit and for issues"I would also recommend adding
php8.1/mysql5.7/Drupal 10 development
as "Run weekly"Having the D10 test available will help work on the D10 compatibility issue even though it will fail tests initially.
- π°πΏKazakhstan NikolayYenbakhtov
I've configured the project to run automated tests as "Run on commit and for issues"
But tests fails (
- πΊπΈUnited States danflanagan8 St. Louis, US
Can you update the php version of the test to 8.1? You have it set at php5.3 which I think is too low.
- π°πΏKazakhstan NikolayYenbakhtov
Yes, you right, I didn't notice php version.
I've changed php version to 8 and then test passed. - πΊπΈUnited States danflanagan8 St. Louis, US
Awesome!
You can set up a test for D10 as well even though we know it will fail. I think it will help work on the D10 compatibility issue if that tests is available.
- π°πΏKazakhstan NikolayYenbakhtov
Thank you, I've added D10 tests!
- πΊπΈUnited States danflanagan8 St. Louis, US
Great! Can you update the D10 tests to use php8.1 also?
Personally, I find it very strange the the interface even allows us to pick php5 when setting up a D10 test! I have made this same mistake many, many times myself. :)
- π°πΏKazakhstan NikolayYenbakhtov
Sorry I didn't pay attention to php version again ).
I changed it to php8.1 - Status changed to Fixed
almost 2 years ago 1:36pm 10 March 2023 - πΊπΈUnited States danflanagan8 St. Louis, US
Thank you so much, @NikolayYenbakhtov!
I'm marking this issue as Fixed.
Cheers!
Automatically closed - issue fixed for 2 weeks with no activity.