- Issue created by @RoSk0
- 🇧🇪Belgium kristiaanvandeneynde Antwerp, Belgium
You want your group canonical route to be a landing page so displaying that in the admin theme makes little sense. The other routes I could agree with, but I never really triggered it for the members and nodes view because of ✨ New option for Views page displays to use the admin theme Fixed
Not really a bug report as it boils down to personal preference and what makes the most sense.
- Status changed to Postponed
over 1 year ago 12:30pm 12 September 2023 - 🇧🇪Belgium kristiaanvandeneynde Antwerp, Belgium
The core issue only just landed in 10.1 so we will have to wait for 9.x support to be dropped before we can start using that. entity.group.version_history now shows in admin theme, so I see no actionable items here until Drupal 10 is the minimum supported core version.
- First commit to issue fork.
- Merge request !165Issue #3346626: Ensure GroupRevisionRouteSubscriber's route altering is... → (Open) created by s_leu
- Status changed to Needs review
8 months ago 8:22am 30 May 2024 entity.group.version_history now shows in admin theme
This seems a to work only randomly depending on the apparently random order of route subscribers, which in you case seemed to be correct. The order seems to be different in my case and to ensure that the admin theme is used, we need the altering in
GroupRevisionRouteSubscriberto run before the one inGroupAdminRouteSubscriber. A corresponding change can be found in the MR.Btw. I wasn't sure which target branch to use, please change it if it's incorrect.
- 🇧🇪Belgium kristiaanvandeneynde Antwerp, Belgium
I would do it the other way around and make the admin subscriber run really late, rather than the revision subscriber run early. This way we don't get the same bug when new route subscribers are introduced.
We should also update the default views and write an update hook to make sure existing installs get the same update.