[3.x] Remove dependency on "drupal/embed" contrib module

I think the biggest benefit of Embed is having the preview route/callback defined for you with additional security checks upcoming like 📌 Deprecate EmbedButtonEditorAccessCheck in favor of a generic access check for "does a filter format or editor have a filter plugin enabled" Active . And not having to fork DomHelperTrait. If there's things I can improve in Embed to help this out, let me know. I could also see separate buttons for YouTube or customizing in the embed type which providers are allowed, which would be possible with the embed plugins to have more than one button for different providers if sites wanted to build it out that way.

I think the biggest benefit of Embed is having the preview route/callback defined for you with additional security checks upcoming

Thanks for this perspective. I had understood inheriting the callbacks from drupal/embed as benefical theoretically, but had assumed that the work on the security checks there were basically "done" at this point. If there is a sense that there will be periodic need to manage the security, then I fully agree that retaining the dependency on drupal/embed is better than trying to keep up with those security changes within drupal/url_embed.

Based on the above, this issue can probably be closed and the 🌱 [META] Roadmap for 3.x branch Active updated to indicate that removing the drupal/embed dependency will not be part of the 3.x version. Leaving this as-is, though, for now, for further maintainer/community input...

Based on the feedback from Dave, above, I'm going to close this issue and remove the plan to remove dependency on drupal/embed from the roadmap for 3.x.