- Issue created by @jsacksick
- Status changed to Needs review
over 1 year ago 8:29am 3 March 2023 -
jsacksick →
committed d1be3e64 on 8.x-2.x
Issue #3345682 by jsacksick: Require commerceguys/intl version 2.
-
jsacksick →
committed d1be3e64 on 8.x-2.x
-
jsacksick →
committed 9c780682 on 3.0.x
Issue #3345682 by jsacksick: Require commerceguys/intl version 2.
-
jsacksick →
committed 9c780682 on 3.0.x
- Status changed to Fixed
over 1 year ago 10:31am 3 March 2023 - 🇮🇱Israel jsacksick
Committed, Physical also had to be updated (See 📌 Align with the commerceguys/intl changes Fixed ). We'll have to coordinate releases.
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
over 1 year ago 7:51pm 12 April 2023 - 🇨🇦Canada samalander
Hi, sorry to be reopening a closed issue.
PHP 7.4 is still supported by Drupal 9 until its end of life.
https://www.drupal.org/docs/getting-started/system-requirements/php-requ... →
Dropping support early means users like me will be unable to receive future updates, especially security updates.
I don't think something like this should be done in a minor release. Especially since issue #3310687 → (Drop PHP7 compatibility) says to only do it for the 3.x branch for now.
Feel free to re-close; I'll just be over here with version 8.x-2.33, crossing my fingers that no security flaw is found in the next 7 months.
- 🇮🇱Israel jsacksick
PHP7 is end of life... See https://php.watch/news/2021/11/php7-eol. So anyone still running PHP7 already exposes himself to bigger security risks.
Sorry, dropping PHP7 compatibility was just easier for me in terms of maintenance. Drupal 10 itself requires PHP 8.1 minimum. Commerce is both compatible with D9 and D10. I tried to retain compatibility with PHP7 as much as I could, but it just created additional maintenance burden for me.
See https://www.drupal.org/project/commerce/issues/3353689#comment-15008620 📌 Keep commerce compatible with PHP 7.3 or 7.4? Closed: won't fix as well.
- 🇨🇦Canada samalander
PHP7 is EOL, true. According to the same page, it remains the most widely used version with nearly 50% usage and is supported by Ubuntu 20.04 LTS (which is what we use) until April 2025, well after Drupal 9 reaches its EOL.
I wasn't necessarily asking to maintain compatibility until the very end. I don't mind staying behind for a few months. I'm worried about what could happen if a security flaw is discovered since installing the updated version won't be possible.
Anyway, I understand your POV. Thanks for the quick response.
- 🇦🇺Australia ac Perth
Dropping PHP support like that is quite a big deal. Obviously it is your choice but this should be mentioned very clearly on the module page. Currently the page says Drupal 9.3 is supported which isn't really true anymore due to points already raised by samalander. I didn't actually realise this had happened until today as it is easy to miss when updating things via composer - commerce just doesn't move past 8.x-2.33