[beta1] Remove useless dependencies to modules

Created on 2 March 2023, almost 2 years ago

Updated 14 March 2023, almost 2 years ago

Problem/Motivation

Currently the theme dependencies are those:

  - component_blocks:component_blocks
  - drupal:inline_form_errors
  - layout_options:layout_options
  - ui_patterns:ui_patterns
  - ui_patterns:ui_patterns_library
  - ui_patterns_settings:ui_patterns_settings
  - ui_styles:ui_styles

The other UI Suite themes have those:

https://git.drupalcode.org/project/ui_suite_bootstrap/-/blob/5.0.x/ui_su...

  - layout_options:layout_options
  - ui_patterns:ui_patterns_library
  - ui_patterns_settings:ui_patterns_settings
  - ui_styles:ui_styles

https://git.drupalcode.org/project/ui_suite_bootstrap/-/blob/4.0.x/ui_su...

  - layout_options:layout_options
  - ui_examples:ui_examples
  - ui_patterns:ui_patterns_library
  - ui_patterns_settings:ui_patterns_settings
  - ui_styles:ui_styles

https://git.drupalcode.org/project/ui_suite_material/-/blob/2.0.x/ui_sui...

Do we really needs those dependencies:

  - layout_options:layout_options
  - ui_patterns:ui_patterns_library
  - ui_patterns_settings:ui_patterns_settings
  - ui_styles:ui_styles
  - ui_examples:ui_examples
  - ui_skins:ui_skins

https://git.drupalcode.org/project/ui_suite_protocol/-/blob/1.0.x/ui_sui...

  - layout_options:layout_options
  - ui_examples:ui_examples
  - ui_patterns:ui_patterns_library
  - ui_patterns_settings:ui_patterns_settings
  - ui_styles:ui_styles

Proposed resolution

So, do we really needs those dependencies?

component_blocks:component_blocks
drupal:inline_form_errors

If not, let's remove them.

📌 Task

Status

Fixed

Version

1.0

Component

Code

Created by

🇫🇷France pdureau Paris

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @pdureau
Assigned to pdureau
Status changed to Needs review almost 2 years ago12:38pm 2 March 2023
Comment almost 2 years ago →
🇺🇦Ukraine andrew_tspkh
Hello Pierre
I've removed component_blocks:component_blocks
But we need drupal:inline_form_errors for forms inputs. As in DSFR error messages are displayed directly bellow the form fields.
MR: https://git.drupalcode.org/project/ui_suite_dsfr/-/merge_requests/2
Comment almost 2 years ago →
System Message

6bbd830e committed on 1.0.x
Issue #3345471 by pdureau, andrew_tspkh: [beta2] Remove useless...
Status changed to Fixed almost 2 years ago2:40pm 2 March 2023
Comment almost 2 years ago →
🇫🇷France pdureau Paris
Status changed to Fixed almost 2 years ago10:00pm 14 March 2023
Comment almost 2 years ago →
🇫🇷France pdureau Paris

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024