Contrib.social

Rate limit check - confusing messaging

Open on Drupal.org →
Created on 1 March 2023, about 2 years ago
Updated 2 May 2023, almost 2 years ago

Problem/Motivation

The current messaging on ApiRateLimitCheck.php is contradictory.
If the rate is below the limit of 1200 every 5 minutes, then the messaging say: 'Site is safely below the rate limit of :rate_limit every 5 minutes.'
However, if you are above the $daily_warning_level or have reached the limit, the wording changes to '... Api limit of :rate_count/:rate_limit limit purges/day.'

Proposed resolution

As the rate_limit in this case is API_RATE_LIMIT, which is currently set to 1200 (every 5 minutes). Then the wording should be changed to say 'every 5 minutes.'

🐛 Bug report
Status

Fixed

Version

2.0

Component

Code

Created by

scambler

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024