Fix core_version_requirements in 8.x-1.x branch to match reality

Hah, bummer, we can't queue a test on 8.9.x core anymore. 😅

p.s. Why this is a bug: If you're on group V1, and try to upgrade to core D10, composer will let you, but the site immediately throws fatal errors. I think this situation will lead to more support requests and hassles for you than just telling people if they're on V1, they need to use D9 as the pivot to start their upgrade journey.

Hrmm... that's... unexpected:

Message was: "Call to undefined method Drupal\Tests\group\Kernel\GroupTypeTest::expectExceptionMessageRegExp()" at
/var/www/html/modules/contrib/group/tests/src/Kernel/GroupTypeTest.php:41
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

Not seeing that locally, on either 8.9.x core nor 9.5.x core. That method is defined in vendor/phpunit/phpunit/src/Framework/TestCase.php. No idea how it went missing for this 1 Kernel test.

Ahh, I see. My local 9.5.x site was still on PHPUnit 8.5.31. Once I run composer run drupal-phpunit-upgrade, I'm seeing the fail locally, too. Sort of orthogonal to this issue, so I guess we should handle that in a separate issue.

Yeah, test suite is green again at 📌 8.x-1.x branch fails testing with PHPUnit 9 due to expectExceptionMessageRegExp() Closed: outdated . That should land first.

Since d.o testbot can't do 8.9 core runs anymore, not sure the best way for you to verify this. Would it be helpful if I write a full local test run's output to file and upload that here?

Or do you basically not care about this branch at all anymore? 😅 Interested in making me a co-maintainer, just for Group V1, just so I can get the 8.x-1.x branch back in solid shape to act as a bridge from the past to the future?

Thanks again!
-Derek

We also have a d10 rector patch for 1.x 📌 Automated Drupal 10 compatibility fixes Closed: outdated

Thank you for starting this issue! This is definitely going to catch other people off guard, like it did me.

Someone who is auditing their site for D10 compatibility with a long list of contrib modules to review is going to see "Works with Drupal: ^9.3 || ^10" and stop reading there, because they are not expecting the release notes to OUTRIGHT LIE to them, even if there is clarification below. They're going to tick this module off as covered for D10 and move on to the others in their list that need attention.

I should also point out that the Upgrade Status module is currently listing all sites on Group 8.x-1.5 as D10 ready. See screenshot:

People are busily preparing for D9 EoL right now. Is "postponed" the correct status for this issue? Postponed until when? Fixing this ASAP will help prevent a lot of nasty surprises.

For the sake of expediency, does this need to be split into 2 separate issues: one to remove the incorrect D10 compatibility statement and another to deal with D8/9 compatibility?

Yes, postponed is accurate since this is blocked (at least) on landing 📌 8.x-1.x branch fails testing with PHPUnit 9 due to expectExceptionMessageRegExp() Closed: outdated first.

I really need to make some time to work on all this again. Sadly, my last few months of paying gigs haven’t been for clients using Group at all. If anyone’s got budget to hire me to sort all this out, it’d be a lot easier to prioritize it.

Thanks / sorry,
-Derek

See 📌 Initiative for Group 1.x compatibility under Drupal 10 Fixed