- Issue created by @herved
- Issue was unassigned.
- Status changed to RTBC
about 2 years ago 1:22am 1 May 2023 - Status changed to Needs review
about 2 years ago 3:45am 4 May 2023 - last update
about 2 years ago 414 pass, 3 fail - last update
about 2 years ago 425 pass, 2 fail - last update
about 2 years ago 425 pass, 2 fail - 🇳🇿New Zealand ericgsmith
Fixed coding standards error in test.
The 2 failed tests are currently failing in the 2.0.x branch ( https://www.drupal.org/pift-ci-job/2658100 → ).
Comment #6 is still just test only addition from #2 which had no failures - I will try remember to come back and retest it assuming the tests in the main branch will get fixed some time soon.
- 🇧🇪Belgium herved
I wonder, does the exclude facet option work with this condition?
I think it won't but I have not tested yet. - 🇳🇿New Zealand ericgsmith
You are correct, this does break the exclude logic.
I think having the separate condition group for the missing condition is correct, and the missing condition group operator could be determined based on the exclude value.
- last update
about 2 years ago 426 pass, 2 fail - 🇳🇿New Zealand ericgsmith
How does that look?
Improved the test a bit to more clearly show the expected condition groups.
- Merge request !303Issue #3344081: The operator used for the missing facet item is incorrect → (Open) created by ericgsmith
- 🇳🇿New Zealand ericgsmith
Moved patch to MR - CI shows test job passing + expected failure of the test only change