Re-assess patches in composer.json and remove where possible

Created on 21 February 2023, over 1 year ago
Updated 20 April 2023, about 1 year ago

Problem/Motivation

Super short version: cweagans/composer-patches that we require is breaking DrupalCI and there's no way to add it to the allow list before DrupalCI does the composer install. For details, see πŸ› Customize DrupalCI config to allow running cweagans/composer-patches; fails otherwise Fixed

Steps to reproduce

Run DrupalCI, get Composer require error.

Proposed resolution

Re-assess which patches we need and whether a new version of a dependency can be required that includes those patches, eventually removing cweagans/composer-patches so that we can run DrupalCI.

Multiselect β†’ module

We currently require version 8.x-1.2 of this which is the latest of that branch; this doesn't contain the fixes we use patches for; the 2.x branch which (at time of writing) has a beta release does contain the fixes from the patches.

It doesn't look look like either issue is necessary for Config Enforce Devel to function, so we could expand the version constraint to add ^2.0 and remove the patches, and most or all users will get the newer version with the fixes while technically not breaking backwards compatibility with Drupal 8, which has been end of life for months now.

Configuration development β†’ module

This one is likely to be the blocker as it doesn't look like the maintainers are present much or at all going back two or three years. Neither of these are even merged, though there is recent activity:

We'll probably have to reach out the maintainers of the module to get these issues looked at once they're ready. We could also ask to be added as maintainers if they don't have time, maybe just temporarily to get these done and released, and then they can remove us as maintainers unless one or more of us have the bandwidth to help out in their issue queue.

Remaining tasks

Do the things.

User interface changes

Minimal or none, depending on Multiselect.

API changes

None?

Data model changes

None?

πŸ“Œ Task
Status

Fixed

Version

1.0

Component

Code

Created by

πŸ‡¨πŸ‡¦Canada Ambient.Impact Toronto

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.69.0 2024