entityqueue_smartqueue_entity_update can be slow

Created on 20 February 2023, over 1 year ago

Problem/Motivation

I've got fairly simple setup in that I have some smartqueues based on a large-ish taxonomy.

When editing the taxonomy to re-order the terms we see incredibly high memory usage and timeouts.

Steps to reproduce

In the above setup, re-order some terms using the Drupal admin UI.

Proposed resolution

As far as I can see it's because if a term is updated, then the associated smartqueue is re-saved. This seems kinda wasteful. It sort of looks like the code is only trying to update the label.

I suppose that there could be other code that is triggering off of this update, so it's possible that we should:

* Stop the save
* Introduce another event
* Bump the API version.

Remaining tasks

Do all the above.

User interface changes

None.

API changes

We'd remove an entity update, and add a new event to cover this.

Data model changes

None.

🐛 Bug report
Status

Needs work

Version

1.0

Component

Code

Created by

🇬🇧United Kingdom steven jones

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024