Block filtering by current timezone and not UTC

error with my first patch, sorry

@asherry, I actually found this bug back in October and fixed it as part of this issue: https://www.drupal.org/project/notification_message/issues/3315255 🐛 Message won't dismiss Fixed . See my commit here: https://git.drupalcode.org/project/notification_message/-/merge_requests...

Our code is very similar, I'm sure yours works fine, but know that my issue has already been RTBC by solideogloria and ready to be merged into dev. Maybe take a look at this patch and see if it works for you? https://git.drupalcode.org/project/notification_message/-/merge_requests...

I see, thanks for letting me know. I had looked through the issue queue, your issue is still titled "Message won't dismiss". The change for the timezone fix wasn't dependent on the other commits so I would recommend having separated that out into another ticket. It's easier to QA for maintainers, and then it's easier to find for other people to use.

I like the use of the interface for the STORAGE_TIMEZONE, you can actually simplify the statement even more to:

$now = new DrupalDateTime('now', DateTimeItemInterface::STORAGE_TIMEZONE);

The DrupalDateTime object actually already converts the timezone to an object.

Sure, I'm kind of new at all this forking/issue stuff and have been finding all these little issues and bugs while trying to use this module on a site that's about to launch. I am up to 3 issues now and it's all getting really hard to manage, especially on my end. We really need the maintainers to chime in here and help corral all these changes and give feedback. Aren't they also at Aten like you?

I'm sorry it's frustrating, I know how you feel. Things can move very slowly in the contrib world, we're all in the same boat. We give as much time as we can, especially when we're using it for a client's site.

I appreciate your work and contributions. If making a patch would be easier than a pull request, that's still a very legitimate way to contribute.

If you want to create one issue with all the bugs then that's also completely valid too. I just suggested making sure the title is up to date so that I know it's not a one-purpose issue.

@asherry, sorry, just getting back to this, yes time gets away from us all! In reviewing my issue/patch for Message won't dismiss → , I noticed in my writeup that I said I only changed 3 files so the snippet that was included about the time zone issue was probably just a hold over from me fixing something else. I totally agree that it shouldn't be in there, has nothing to do with fixing the dismissal issue. Once I have a chance to get back to this, I'll redo it and incorporate your patch here so no need to update the title :)