Content Generator Temperature validation

Created on 16 February 2023, over 1 year ago
Updated 22 May 2023, about 1 year ago

The latest alpha2 has a temperature validation of 0.1<>1, but should be 0<>1. This can be fixed by changing ContentGenerationConfigForm.php, line 273 'min' value from 0.1 to 0.

πŸ› Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States d0t101101

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @d0t101101
  • πŸ‡ΊπŸ‡ΈUnited States d0t101101

    Similarly, when running drush openai:generate-content (which needs updated in the README.MD BTW!), the validation around temperature wasn't working. In ContentGenerateCommand.php, line 179, I changed 'is_float' to 'is_numeric' to correct this.

    Along with my manual testing of both the Content Generation form and drush, it would be great to set the default values for the Content Type/Title/Body fields somehow. Having to select them every time via the form slows down the process, and there isn't a way to do this during the interactive drush command. In drush, after going through the steps and 'Proceed with operation', in my environment, it bombs out not knowing where to store the response with:

     [warning] Undefined array key "content_type" ContentGenerationCommand.php:101
     [warning] Undefined array key "title" ContentGenerationCommand.php:102
     [warning] Undefined array key "body" ContentGenerationCommand.php:103
    

    (and then a slew of errors around these missing arguments...)

    Are there any plans to set these values via the OpenAI config pages somehow? Would also be handy to be able to create content via drush with a single terminal command (i.e. all options could be set via the CLI).

    Thanks!!!

  • πŸ‡ΊπŸ‡ΈUnited States kevinquillen

    Yeah, both the image generation and the Drush command will need some attention. I didn't get a chance today to touch them.

  • πŸ‡ΊπŸ‡ΈUnited States d0t101101

    @kevinquillen - good catch, the upper limit of the MAX is 2 as you already wired in here. Nice! :)

    https://platform.openai.com/docs/api-reference/completions#completions/c...

  • Status changed to Fixed about 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States kevinquillen

    Marking as fixed, this was also in a module that has now been deprecated.

  • πŸ‡ΊπŸ‡ΈUnited States kevinquillen
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024