Contrib.social

TitleFormatter should extend StringFormatter

Open on Drupal.org →
Created on 16 February 2023, over 1 year ago
Updated 26 February 2023, over 1 year ago

Problem/Motivation

TitleFormatter currently extends from BasicStringFormatter. However StringFormatter would be a much better starting point as it already has one of the settings that TitleFormatter is adding.

The code in StringFormatter has some improvements

  1. Doesn't force the link render array to string in viewElements().
  2. Correctly handles revisions.

Unfortunately the setting in StringFormatter has a different name: link_to_entity instead of linked.

Proposed resolution

  1. Change TitleFormatter to extend StringFormatter.
  2. Write an update hook to fix the setting name in existing display settings.

Remaining tasks

User interface changes

Slight differences in formatter settings.

API changes

None

Data model changes

Change of formatter setting name link_to_entity instead of linked.

📌 Task
Status

Fixed

Version

3.0

Component

Code

Created by

🇬🇧United Kingdom AdamPS

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024