Mess with bootstrap bridge

Created on 10 February 2023, almost 2 years ago
Updated 28 April 2023, over 1 year ago

Problem/Motivation

When enabling the external_link_popup module with the boostrap theme, I get that console message :
Uncaught TypeError: Cannot set property 'Bridge' of undefined
... and a regression on all other popups on my site (they open once).

Steps to reproduce

Enable external_link_popup with the bootstrap theme (at least v3.24)
You should see the console erreur on every web page.

Proposed resolution

It seems core/drupal.dialog dependency in external_link_popup.libraries.yml brings disorder

dialog:
  version: VERSION
  js:
    js/dialog.js: {}
  dependencies:
    - core/jquery.once
    #- core/drupal.dialog

Remaining tasks

Not sure this patch needs to be reviewed and committed.
I just share it there, who knows, it might be useful for others who use bootstrap theme , boostrap_external_link_popup and external_link_popup

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Closed: works as designed

Version

1.12

Component

Code

Created by

🇫🇷France pguillard

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024