Contrib.social

Plan to migrate to core's RevisionHtmlRouteProvider

Open on Drupal.org →
Created on 9 February 2023, over 1 year ago
Updated 16 March 2023, over 1 year ago

Problem/Motivation

✨ Implement a generic revision UI Fixed gave us a nice generic revision UI with routing, link templates, etc. We should make a plan for how we're going to migrate LibraryItem entities to use it.

The main issues I see are with the revert/delete routes and link templates which are named slightly differently (currently revision_revert instead of revision_revert_form)

https://git.drupalcode.org/project/drupal/-/merge_requests/2910/diffs is an example of converting block_content to use it.

Proposed resolution

We will probably need to roll a new major, that's only compatible with 10.1

We then need to:

  1. Add the revision route provider
  2. Deprecate the old revert and delete revision routes
  3. Deprecate the old revert and delete revision link templates (is this possible?)
  4. ???

Remaining tasks

Solidify approach.

🌱 Plan
Status

Needs work

Version

1.0

Component

Module: Library

Created by

🇦🇺Australia acbramley

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @acbramley
  • First commit to issue fork.
  • @enyug opened merge request.
  • Status changed to Needs work over 1 year ago
  • Comment over 1 year ago →
    🇦🇺Australia acbramley

    There's still a bit of work here around deprecations, can we also close the 9.5 MR and open one against the 10.1 branch? There's no way this can work with 9.5 as the generic UI is 10.1 only.

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024