PubSubHubbub is using removed Guzzle dependencies

Created on 9 February 2023, almost 2 years ago
Updated 13 February 2023, almost 2 years ago

Problem/Motivation

Drupal\feeds\EventSubscriber\PubSubHubbub.php is using


    use GuzzleHttp\Url;

    // Used to make other URLs absolute.
    $source_url = Url::fromString($feed->getSource());

    $hub = (string) $source_url->combine($hub);

Which are no longer existing nor supported on 6.0 version of the GuzzleHttp library.

Proposed resolution

Use an alternative for making URLs absolute and combining them.

Reading the Upgrade.md file of guzzlehttp/guzzle library, it states that from 6.0:

- Guzzle now uses `Psr\Http\Message\UriInterface` (implements in
`GuzzleHttp\Psr7\Uri`) for URI support. `GuzzleHttp\Url` is now gone.

But neither `Psr\Http\Message\UriInterface` nor `GuzzleHttp\Psr7\Uri` can be considered drop-in replacements as they don't implement static `fromString` or `combine` methods.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Closed: works as designed

Version

1.0

Component

Code

Created by

🇪🇸Spain idiaz.roncero Madrid

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024