- Issue created by @bander2
- Status changed to Fixed
about 1 year ago 8:04am 9 June 2023 - 🇸🇰Slovakia kaszarobert
I committed your patch. Thanks for the contribution!
Automatically closed - issue fixed for 2 weeks with no activity.
Performance hit with large tables.
Make a large table.
Open /src/Listener/ExtendedMarkdown.php and time how long line 58 takes:
$extensions = $this->getExtensions();
I used Devel and wrapped it like this:
$ex = hrtime(true);
$extensions = $this->getExtensions();
dpm((hrtime(true) - $ex)/1000000000, 'ex');
Then clear cache and load the page with the table.
I found that extensions were loaded once for each cell in my table and that this method call took about 0.25 seconds each. It quickly added up.
I don't think we really need a new instance of extensions for each cell processed, so we can just cache them the first time they are requested.
Cache extensions.
none
none
none
Fixed
2.0
Code
I committed your patch. Thanks for the contribution!
Automatically closed - issue fixed for 2 weeks with no activity.