- Issue created by @Finn Lewis
- 🇬🇧United Kingdom cbrody
Thanks @finn-lewis, seems to me that search_api is the logical place to fix this.
- Status changed to Needs review
almost 2 years ago 11:18am 25 February 2023 - 🇦🇹Austria drunken monkey Vienna, Austria
Thanks for reporting this issue!
I guess it really is high time to think of a solution for this. How about something like the attached patch? I think, since there is a base class, the changes should be allowed under our BC policy, and this seems to resolve the problem.
Please test/review!
- 🇦🇹Austria drunken monkey Vienna, Austria
Would be great to get feedback on my patch before I commit it, to make sure it actually fixes the problem.
- 🇬🇧United Kingdom Finn Lewis
Thanks drunken monkey!
I've tested this in the installation that was giving us the original problem reported on https://www.drupal.org/project/search_api_solr/issues/3326515 🐛 "can not use FieldCache on multivalued field" error when using boost recent dates processor Fixed
It does not fix the original problem but I can see that Saerch API is no longer declaring the aggregated field as a list, which is nice!
But now in search_api_solr the logic continues on from https://git.drupalcode.org/project/search_api_solr/-/blob/4.2.9/src/Plug...
to https://git.drupalcode.org/project/search_api_solr/-/blob/4.2.9/src/Plug...
where this line still sets the prefix to dm_
$pref .= $this->getPropertyPathCardinality($field->getPropertyPath(), $index_properties) != 1 ? 'm' : 's';
So I need to understand why the getPropertyPathCardinality is not returning 1 for the aggregated field.
So I think the patch looks good but perhaps reveals another part of the problem back in search_api_solr.
I'll follow up with that over on https://www.drupal.org/project/search_api_solr/issues/3326515 🐛 "can not use FieldCache on multivalued field" error when using boost recent dates processor Fixed
- 🇳🇱Netherlands Gertlor
I've made a patch to fix the problem reported by #6, see https://www.drupal.org/project/search_api_solr/issues/3326515#comment-14... 🐛 "can not use FieldCache on multivalued field" error when using boost recent dates processor Fixed
- 🇬🇧United Kingdom Finn Lewis
Thanks @Gertlor !
I've tested this patch with the patch on https://www.drupal.org/project/search_api_solr/issues/3326515#comment-14... 🐛 "can not use FieldCache on multivalued field" error when using boost recent dates processor Fixed and it does resolve our problem.
Is that enough for you to commit and perhaps get a new release @drunken monkey?
- Status changed to RTBC
almost 2 years ago 6:14pm 20 March 2023 - 🇩🇪Germany mkalkbrenner 🇩🇪
I agree with #4. Once it is committed, we can proceed in search_api_solr.
-
drunken monkey →
committed cea94cd2 on 8.x-1.x
Issue #3340305 by drunken monkey: Fixed all aggregated fields being...
-
drunken monkey →
committed cea94cd2 on 8.x-1.x
- Status changed to Fixed
over 1 year ago 5:52pm 25 March 2023 - 🇦🇹Austria drunken monkey Vienna, Austria
Good to hear, thanks for your feedback!
Committed. Thanks again, everyone!I also posted a change notice → for this.
Automatically closed - issue fixed for 2 weeks with no activity.