- Issue created by @pdureau
- 🇫🇷France pdureau Paris
Careful about this:
ui_suite_dsfr_preprocess_pattern_footer(array &$variables) > default value related to the current website state
Because service_title is missing from footer definition:
function ui_suite_dsfr_preprocess_pattern_footer(array &$variables) { if (empty($variables['service_title'])) { $variables['service_title'] = \Drupal::config('system.site')->get('name'); } }
- Status changed to Needs work
over 1 year ago 10:16pm 22 June 2023 - 🇫🇷France pdureau Paris
Usual work (we did the same tasks for other UI Suite themes)
- Replace _ui_suite_dsfr_add_class by add_class filter > DONE in commit 889ccd6
- Use preview templates > DONE in commit 889ccd6
- Use menu setting type > TODO
Specific to DSFR:
- Replace _ui_suite_dsfr_add_elements_attributes by create_attribute() in templates > DONE in commit 889ccd6
- Replace _ui_suite_dsfr_add_link_class by add_class filter > TODO
- Status changed to Postponed
over 1 year ago 6:14pm 18 September 2023 - Status changed to Needs work
about 1 year ago 8:42am 30 October 2023 - 🇫🇷France pdureau Paris
https://www.drupal.org/project/ui_patterns_settings/releases/8.x-2.1 → is out!
We can resume work. - Merge request !48Issue #3340244 by pdureau: Replace _ui_suite_dsfr_add_link_class by add_class filter → (Merged) created by pdureau
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 3:47pm 12 November 2023 - 🇫🇷France pdureau Paris
Done: https://git.drupalcode.org/project/ui_suite_dsfr/-/merge_requests/48/com...
It works perfectly, but I'm waiting for the little bug on the preview page to be fixed before merging: https://www.drupal.org/project/ui_patterns_settings/issues/3345071#comme... ✨ Add links setting type Needs review
However, everybody is welcomed to have a review
- Status changed to Fixed
about 1 year ago 4:26pm 7 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.