- Issue created by @tr
- First commit to issue fork.
- @_pratik_ opened merge request.
- π΅πΉPortugal jcnventura
@pratik_specbee, please read the issue summary...
- Status changed to Needs work
about 2 years ago 7:17pm 6 February 2023 - Status changed to Needs review
about 2 years ago 8:39pm 6 February 2023 The last submitted patch, 6: 3339459-6-type-hints-in-tests.patch, failed testing. View results β
- Status changed to Needs work
about 2 years ago 8:54pm 6 February 2023 - πΊπΈUnited States tr Cascadia
Adding type hints revealed a typing problem in the tests. Needs work to fix this.
- Status changed to Needs review
about 2 years ago 9:49pm 6 February 2023 - π¦πΊAustralia acbramley
We can't type $result or $simplified_result as they can be a string or an array. We can't use union types because we are still supporting
- Status changed to RTBC
about 2 years ago 4:02pm 9 February 2023 - π΅πΉPortugal jcnventura
This only changes test files. The changes are in-line with the changes required for the tests to pass with D10, and the tests are passing.
- Status changed to Needs review
about 2 years ago 7:57pm 14 February 2023 - πΊπΈUnited States tr Cascadia
Here's a new patch that starts with #9 and also corrects (and documents) the @return type in MimeMailFormatHelper to include an array in the same way that was done in the test. I think this is still in scope because the whole point of adding type hinting in the tests is to ensure that we're always passing around what we think we're passing around, and since we're not we have to make sure the documentation comments have the right types everywhere.
- Status changed to Fixed
about 2 years ago 11:36pm 15 February 2023 Automatically closed - issue fixed for 2 weeks with no activity.