Created on 3 February 2023, over 1 year ago
Updated 27 October 2023, 8 months ago

Problem/Motivation

The form on the "export" page looks it has already been ported. However, does it work as it should when the form is submitted? Compare with the behaviour in the Drupal 7 version (see code).

Remaining tasks

  • Check whether the form is entirely ported (buildForm()).
  • Check what happens on submit.
๐Ÿ“Œ Task
Status

Fixed

Version

3.0

Component

l10n_packager

Created by

๐Ÿ‡ซ๐Ÿ‡ทFrance FMB Perpinyร , Catalonia, EU

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @FMB
  • ๐Ÿ‡ซ๐Ÿ‡ทFrance FMB Perpinyร , Catalonia, EU
  • Assigned to Artusamak
  • ๐Ÿ‡ซ๐Ÿ‡ทFrance Artusamak Bzh

    Having a look at it.

  • Issue was unassigned.
  • Status changed to Needs work 9 months ago
  • ๐Ÿ‡ซ๐Ÿ‡ทFrance Artusamak Bzh

    I have a working export form. I rephrased the export options to be consistent and understandable since what we had in ldo was sometime surprising as an export result.

    Remaining tasks are:

    * Trying to cleanup the URI value expected to be an internal project ID in \Drupal\l10n_community\Controller\L10nCommunityLanguagesController::export().
    * Doing additional testing with the ajax selector that have inconsistent behavior based on the step you follow to export (sometime the releases are not listed, sometime they generate an error). It's hard to define the blocking steps to reproduce.

    I didn't open the merge request yet since the first remaining task is important to be cleanup in my opinion (but the commits are shared).

  • ๐Ÿ‡ซ๐Ÿ‡ทFrance Artusamak Bzh

    Two above points are fixed.

    There is now the last step not working which is the project selection with autocomplete. I managed to extract the project ID from the autocomplete response but the AJAX process triggers the form submission despite not having clicked on "Export Gettext file".

    I tried the tricks to use $form_state->setRebuild() in the ajax callback or the #limit_validation_errors attribute but it didn't change the outcome. When i input a project name in the field, the form is fully submitted and the triggering element is set to the full form (which is what we DONT want).

    Once this issue is solved, the export form will be fully functional.

  • Assigned to Artusamak
  • ๐Ÿ‡ซ๐Ÿ‡ทFrance Artusamak Bzh

    Trying to discuss with Thomas how to solve it.

  • @artusamak opened merge request.
  • Issue was unassigned.
  • Status changed to Needs review 8 months ago
  • ๐Ÿ‡ซ๐Ÿ‡ทFrance Artusamak Bzh

    Alright, the MR is now reviewable. Thank you TeeBeeCoder for the pair programming.

    I allowed myself to rephrase the form input labels and comments to try to be more explicit for new comers.
    I also added code context for the choices made in the MR.

  • Status changed to Fixed 8 months ago
  • ๐Ÿ‡ซ๐Ÿ‡ทFrance FMB Perpinyร , Catalonia, EU

    Thanks for the hard work @Artusamak and @TeeBeeCoder!

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024