Contrib.social

Scale and crop image effect is not working

Open on Drupal.org →
Created on 1 February 2023, almost 2 years ago
Updated 24 February 2023, almost 2 years ago

I'm using an install of 9.5 with the 1.0.x-dev version of the module. Image scale and crop effect does not seem to be working. Crop seems to work. I can see Widen url being created with crop set to true. Scale effect works and adds the values to the url. But scale and crop does not. The url created has no parameters added. I'm not seeing any errors reported.

Example:
<img src="https://abc123.widen.net/content/6af87bc6-b246-4462-969e-4c1984b1d7f5/web/IMG_23.jpg?itok=YcrbBDmy" width="200" height="200" alt="IMG_23.jpg" loading="lazy">

The correct height and width is added for the image tag, but no parameters. I know the image style works as intended because I use it on another field on the same content, using a regular file upload.

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇺🇸United States davidhernandez USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @davidhernandez
  • Status changed to Postponed: needs info almost 2 years ago
  • Comment almost 2 years ago →
    🇺🇸United States mglaman WI, USA

    Can you provide examples on how the image style is configured? I see that the URL is missing the customization query parameters, which is incorrect.

    How is it being rendered? In the WYSIWYG or a field formatter?

  • Assigned to mglaman
  • Status changed to Active almost 2 years ago
  • Comment almost 2 years ago →
    🇺🇸United States mglaman WI, USA

    The code will be in \Drupal\acquia_dam\EmbedCodeUrlBuilder::mapImageEffects. I'm reviewing our test coverage for the image_scale_and_crop plugin. It looks like that is missing.

    We support the following image effects:

    - focal_point_scale_and_crop
    - focal_point_crop
    - image_convert
    - image_rotate
    - image_resize
    - image_crop
    - image_scale

    I am going to dig through some old notes and issues. I don't know why this was missed, but I remember we had discussed it. It should be similar to how we handle focal_point_crop but the anchor comes from the image style directly.

  • @mglaman opened merge request.
  • Issue was unassigned.
  • Status changed to Needs review almost 2 years ago
  • Comment almost 2 years ago →
    🇺🇸United States mglaman WI, USA

    I made an MR which should fix this image effect.

  • Comment almost 2 years ago →
    System Message
    • mglaman → authored 9194a998 on 1.0.x 
      Issue #3338384 by mglaman: Scale and crop image effect is not working (#...
  • Status changed to Fixed almost 2 years ago
  • Comment almost 2 years ago →
    🇺🇸United States mglaman WI, USA
  • Comment over 1 year ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

  • Comment over 1 year ago →
    System Message
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024