- Issue created by @jay jangid
- @jay-jangid opened merge request.
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 10:40am 1 February 2023 - 🇵🇹Portugal jcnventura
There were a few extra coding standards after applying the MR:
FILE: /home/jcv/drupal/git/stackpath/README.md ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 16 | WARNING | Line exceeds 80 characters; contains 98 characters ---------------------------------------------------------------------- FILE: /home/jcv/drupal/git/stackpath/src/StackPathApi.php --------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 2 WARNINGS AFFECTING 2 LINES --------------------------------------------------------------------------------------------------------------------- 10 | WARNING | [x] Unused use statement 10 | ERROR | [x] Non-namespaced classes/interfaces/traits should not be referenced with use statements 17 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name --------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------- FILE: /home/jcv/drupal/git/stackpath/stackpath.services.yml ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 4 | ERROR | [x] Expected 1 newline at end of file; 0 found ---------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------
- Status changed to Needs work
almost 2 years ago 1:26pm 7 February 2023 -
jcnventura →
authored 91f4fdab on 8.x-1.x
Issue #3338218 by Jay Jangid, jcnventura: Drupal Coding Standards Issues...
-
jcnventura →
authored 91f4fdab on 8.x-1.x
- Status changed to Fixed
almost 2 years ago 1:29pm 7 February 2023 Automatically closed - issue fixed for 2 weeks with no activity.