- Issue created by @Oulalahakabu
- π«π·France Oulalahakabu
I did not investigate a lot, just maked it work
- πͺπͺEstonia hkirsman
Where do you see it and which Drupal are you using?
- π«π·France Oulalahakabu
Same as tests, 9.5.2 stable (bootstrap 3 based theme if it comes from there)
- πͺπͺEstonia hkirsman
What version of Bootstrap are you using? I can't see the error.
- π«π·France Oulalahakabu
https://www.drupal.org/project/bootstrap/releases/8.x-3.25 β
I do not know where and why this error occurs, i did not investigate at all. Bootstrap was just an assumption, hope i can give time to this next weeks :(
- πͺπͺEstonia hkirsman
Maybe sharing composer.json and composer.lock would shed some more light on this?
- πΊπΈUnited States ansonwhan
We encountered the same exception while doing a cache clear from the UI after upgrading to this version, running Core version 9.4.8. This was without the patch.
Symfony\Component\DependencyInjection\Exception\ServiceCircularReferenceException: Circular reference detected for service "extension.list.module", path: "extension.list.module -> config.factory -> high_contrast.overrider -> theme.manager -> theme.registry". in Drupal\Component\DependencyInjection\Container->get() (line 146 of /mnt/www/html/mccloskeymr/docroot/core/lib/Drupal/Component/DependencyInjection/Container.php).
The error is not encountered when running cache clear via Drush.
- @hkirsman opened merge request.
- πͺπͺEstonia hkirsman
Thank you, @ansonwhan . I finally saw the error by clearing cache from UI.
The original patch seems ok, I've updated it a little bit and added a some not related things that confused me (and would probably confuse any other admin)
All in all it seems we can't use theme.manager dependency injection when overriding configs from module (with the config.factory.override way in high_contrast.services.yml).
There's was actually a comment there in our code from the past:
// Not using dependency injection to prevent circular references.
I think at some point we thought hey, why aren't we using dependency injection like proper modules should do and broke it again.
Sorry for the troubles. Could you check the merge request and patch from there (the "plain diff" link)?
- πͺπͺEstonia hkirsman
While we have MR for this, i've also pinged about it on core issue queue https://www.drupal.org/project/drupal/issues/3342938 π¬ Circular reference detected for service "theme_handler" on cache clear Closed: outdated
-
hkirsman β
committed b1b49dc2 on 8.x-1.x
Issue #3338147: Circular reference detected for service "theme_handler...
-
hkirsman β
committed b1b49dc2 on 8.x-1.x
- πͺπͺEstonia hkirsman
Commited the changes, going for another release.
- Status changed to Fixed
over 1 year ago 5:59pm 3 March 2023 - πͺπͺEstonia hkirsman
I hope it's good now. I'm setting this to fixed, new release is out.
Automatically closed - issue fixed for 2 weeks with no activity.