Drupal Coding Standards Issues | phpcs

Open on Drupal.org →

Created on 31 January 2023, almost 2 years ago

Updated 20 October 2023, about 1 year ago

Problem/Motivation

Getting Following errors/warnings

$ phpcs --standard=Drupal views_filters_combine_field

FILE: ...esktop\task\views_filters_combine_field\js\views_filters_combine_fields.js
--------------------------------------------------------------------------------
FOUND 71 ERRORS AFFECTING 9 LINES
--------------------------------------------------------------------------------
   1 | ERROR | [x] End of line character is invalid; expected "\n" but found
     |       |     "\r\n"
  21 | ERROR | [x] Expected 1 space before "="; 0 found
  21 | ERROR | [x] Expected 1 space after "="; 0 found
  33 | ERROR | [x] Expected 1 space before "<"; 0 found
  33 | ERROR | [x] Expected 1 space after "<"; 0 found
  33 | ERROR | [x] Expected 1 space before "="; 0 found
  33 | ERROR | [x] Expected 1 space after "="; 0 found
  33 | ERROR | [x] Expected 1 space before "="; 0 found
  33 | ERROR | [x] Expected 1 space after "="; 0 found
  33 | ERROR | [x] Expected 1 space before "="; 0 found
  33 | ERROR | [x] Expected 1 space after "="; 0 found
  33 | ERROR | [x] Expected 1 space before "-"; 0 found
  33 | ERROR | [x] Expected 1 space after "-"; 0 found
  33 | ERROR | [x] Expected 1 space before "-"; 0 found
  33 | ERROR | [x] Expected 1 space after "-"; 0 found
  33 | ERROR | [x] Expected 1 space before "="; 0 found
  33 | ERROR | [x] Expected 1 space after "="; 0 found
  33 | ERROR | [x] Expected 1 space before ">"; 0 found
  33 | ERROR | [x] Expected 1 space after "<"; 0 found
  33 | ERROR | [x] Expected 1 space before "/"; 0 found
  33 | ERROR | [x] Expected 1 space after "/"; 0 found
  33 | ERROR | [x] Expected 1 space before ">"; 0 found
  33 | ERROR | [x] Expected 1 space after ">"; 0 found
  55 | ERROR | [x] Expected 1 space before "="; 0 found
  55 | ERROR | [x] Expected 1 space after "="; 0 found
  59 | ERROR | [x] Expected 1 space before "="; 0 found
  59 | ERROR | [x] Expected 1 space after "="; 0 found
  77 | ERROR | [x] Expected 1 space before "="; 0 found
  77 | ERROR | [x] Expected 1 space after "="; 0 found
  82 | ERROR | [x] Expected 1 space before "<"; 0 found
  82 | ERROR | [x] Expected 1 space after "<"; 0 found
  82 | ERROR | [x] Expected 1 space before "="; 0 found
  82 | ERROR | [x] Expected 1 space after "="; 0 found
  82 | ERROR | [x] Expected 1 space before "="; 0 found
  82 | ERROR | [x] Expected 1 space after "="; 0 found
  82 | ERROR | [x] Expected 1 space before "="; 0 found
  82 | ERROR | [x] Expected 1 space after "="; 0 found
  82 | ERROR | [x] Expected 1 space before "-"; 0 found
  82 | ERROR | [x] Expected 1 space after "-"; 0 found
  82 | ERROR | [x] Expected 1 space before "-"; 0 found
  82 | ERROR | [x] Expected 1 space after "-"; 0 found
  82 | ERROR | [x] Expected 1 space before "="; 0 found
  82 | ERROR | [x] Expected 1 space after "="; 0 found
  82 | ERROR | [x] Expected 1 space before "="; 0 found
  82 | ERROR | [x] Expected 1 space after "="; 0 found
  82 | ERROR | [x] Expected 1 space before "="; 0 found
  82 | ERROR | [x] Expected 1 space after "="; 0 found
  82 | ERROR | [x] Expected 1 space before ">"; 0 found
  82 | ERROR | [x] Expected 1 space after ">"; 0 found
  99 | ERROR | [x] Expected 1 space before "="; 0 found
  99 | ERROR | [x] Expected 1 space after "="; 0 found
 104 | ERROR | [x] Expected 1 space before "<"; 0 found
 104 | ERROR | [x] Expected 1 space after "<"; 0 found
 104 | ERROR | [x] Expected 1 space before "="; 0 found
 104 | ERROR | [x] Expected 1 space after "="; 0 found
 104 | ERROR | [x] Expected 1 space before "="; 0 found
 104 | ERROR | [x] Expected 1 space after "="; 0 found
 104 | ERROR | [x] Expected 1 space before "="; 0 found
 104 | ERROR | [x] Expected 1 space after "="; 0 found
 104 | ERROR | [x] Expected 1 space before "-"; 0 found
 104 | ERROR | [x] Expected 1 space after "-"; 0 found
 104 | ERROR | [x] Expected 1 space before "-"; 0 found
 104 | ERROR | [x] Expected 1 space after "-"; 0 found
 104 | ERROR | [x] Expected 1 space before "="; 0 found
 104 | ERROR | [x] Expected 1 space after "="; 0 found
 104 | ERROR | [x] Expected 1 space before "="; 0 found
 104 | ERROR | [x] Expected 1 space after "="; 0 found
 104 | ERROR | [x] Expected 1 space before "="; 0 found
 104 | ERROR | [x] Expected 1 space after "="; 0 found
 104 | ERROR | [x] Expected 1 space before ">"; 0 found
 104 | ERROR | [x] Expected 1 space after ">"; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 71 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...\task\views_filters_combine_field\src\Plugin\views\filter\CombineField.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found
   |       |     "\r\n"
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 491ms; Memory: 10MB

Proposed resolution

Fix the errors and warnings.

🐛 Bug report

Status

Version

2.0

Component

Code

Created by

🇮🇳India Jay Jangid

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Comments & Activities

Issue created by @Jay Jangid
@jay-jangid opened merge request.
Issue was unassigned.
Status changed to Needs review almost 2 years ago12:07pm 31 January 2023
Comment almost 2 years ago →
🇮🇳India Jay Jangid
Created MR ,please review.

Thank you.
Status changed to Needs work almost 2 years ago2:34pm 8 February 2023
Comment almost 2 years ago →
🇮🇳India jitesh_1 Jaipur
Hello @Jay Jangid,
After applying mr the module is not working.
Comment over 1 year ago →
mukesh88
PHPCs issue fixes
Status changed to Needs review over 1 year ago8:17am 24 March 2023
Comment over 1 year ago →
mukesh88
Comment over 1 year ago →
🇮🇳India vandna b
#5 patch is failed to apply.
Status changed to Needs work over 1 year ago7:37am 1 August 2023
Comment over 1 year ago →
🇮🇳India keshavv India
@mukesh88 #5 patch Failed to apply. Due to some recent code changes.

I reviewed the MR as well and confirmed that there are some unnecessary changes. Can you please update the MR instead of creating a patch or can you please reroll the patch with the latest code?

Thank you.
First commit to issue fork.
Status changed to Needs review about 1 year ago6:23am 20 October 2023
Comment about 1 year ago →
🇮🇳India zkhan.aamir
Issue summary updated
Assigned to chetan 11
Comment about 1 year ago →
🇮🇳India chetan 11
Issue was unassigned.
Status changed to RTBC about 1 year ago6:41am 20 October 2023
Comment about 1 year ago →
🇮🇳India chetan 11
Hi,
The given MR #9 is resolving all the phpcs error on the above module.
Moving this to +RTBC.
Thanks

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024