- Issue created by @mvogel
- Status changed to Needs review
almost 2 years ago 2:38pm 30 January 2023 - 🇨🇭Switzerland wengerk Lausanne
May you also consider adding tests coverage over the checkbox (checked can be open, unchecked can't be openend).
- Status changed to Needs work
almost 2 years ago 2:42pm 30 January 2023 - Merge request !7Issue #3337623: CKEditor 5: Make adding css classes optional for users → (Closed) created by mvogel
- Status changed to Needs review
almost 2 years ago 7:52am 13 February 2023 - 🇨🇭Switzerland wengerk Lausanne
Thanks mvogal, I have rework the whole patch as a PR on https://github.com/antistatique/drupal-editor-advanced-image/pull/36
Here is the corresponding patch.I mostly change the name of the config (
editable->disable_balloon) and add tests coverage. The last submitted patch, 7: 3337623-07.patch, failed testing. View results →
- Status changed to Needs work
almost 2 years ago 8:51am 13 February 2023 - 🇨🇭Switzerland wengerk Lausanne
Here is the patch with fixed tests of
CKEditor4to5UpgradeCompletenessTest::testButtonsWithTestOnlyModulethat works on 9.5.3 and 9.5.x. - Status changed to Needs review
almost 2 years ago 9:06am 13 February 2023 - Status changed to RTBC
almost 2 years ago 12:48pm 13 February 2023 - 🇩🇪Germany mvogel
Thank you for the quick replies. I am ok with disable_balloon. The PR looks good and I tested it successfully locally. 👍
- Status changed to Fixed
almost 2 years ago 7:33am 14 February 2023 - 🇨🇭Switzerland wengerk Lausanne
Automatically closed - issue fixed for 2 weeks with no activity.