CKEditor 5: Default image CSS classes are not automatically applied

May you please consider adding a coverage that ensure class are applied by default one submission.

Thanks mvogel ! I've rework this patch as a PR on (https://github.com/antistatique/drupal-editor-advanced-image/pull/38).

I'll wait to generate the appropriate patch once #3337618 has been merged.

Here is the patch including code of #3337618

The last submitted patch, 6: 3337618-05.patch, failed testing. View results →

Here is the patch with fixed tests of CKEditor4to5UpgradeCompletenessTest::testButtonsWithTestOnlyModule that works on 9.5.3 and 9.5.x.

Open for suggestions before mering @mvogel → .

I also like to have a review from your point of view as it was a request from you :)

Rerolled PR works for me. Thanks for your work. :)

Automatically closed - issue fixed for 2 weeks with no activity.

Hi,

sorry to be a grave digger. But we are just now working on CKEditor 5 update on my site, and it seems that your commit d0a43eb6 lost the crucial line from the patch #8 and MR/PR

diff --git a/js/ckeditor5_plugins/editorAdvancedImage/src/EditorAdvancedImageCommand.js b/js/ckeditor5_plugins/editorAdvancedImage/src/EditorAdvancedImageCommand.js
index ee7a681..b39d3a4 100644
--- a/js/ckeditor5_plugins/editorAdvancedImage/src/EditorAdvancedImageCommand.js
+++ b/js/ckeditor5_plugins/editorAdvancedImage/src/EditorAdvancedImageCommand.js
@@ -72,6 +72,9 @@ export default class EditorAdvancedImageCommand extends Command {
     if (element.hasAttribute("id")) {
       this.attributes.id = element.getAttribute("id");
     }
+
+    // Force an execution at refresh time in order to set attributes even when the Balloon form has still not been used.
+    this.execute(this.attributes);
   }
 
   /**

that fixes the bug from the issue.

Here a new MR with the code https://git.drupalcode.org/project/editor_advanced_image/-/merge_request...

Now that the module implements Gitlab-CI it will be easier to works & run tests.
Can you review and tests this in order to merge it mvogel ?

wengerk → changed the visibility of the branch 3337618-ckeditor-5-default to hidden.

Merging in progress many, many thanks for your huge contribution to the project improvement mvogel

wengerk → closed merge request !6